Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: deleting policies does not delete associated records with mysql driver #326

Closed
johnwu96822 opened this issue Dec 14, 2016 · 5 comments
Closed

sql: deleting policies does not delete associated records with mysql driver #326

johnwu96822 opened this issue Dec 14, 2016 · 5 comments
Labels
bug Something is not working.
Milestone
0.7.0: Stability ...

Comments

@johnwu96822
Copy link
Contributor

johnwu96822 commented Dec 14, 2016 •
edited
Loading

In MySQL there are four tables for ladon policies. When deleting a policy, it is only deleted from "ladon_policy" table, but the data for this policy in three other ladon_policy_* tables are not removed.
@johnwu96822 johnwu96822 changed the title Issue with SQL datastore: Deleting policies does not delete associated records Issue on SQL impl: Deleting policies does not delete associated records Dec 14, 2016
@aeneasr aeneasr mentioned this issue Dec 19, 2016
Closed
@johnwu96822
Copy link
Contributor Author

This happens on MySQL

@aeneasr aeneasr added the bug Something is not working. label Dec 20, 2016
@aeneasr
Copy link
Member

aeneasr commented Dec 20, 2016

@johnwu96822 is this a critical issue for you?

@johnwu96822
Copy link
Contributor Author

@arekkas Yes we have deployed Hydra for testing. If this issue doesn't get fixed and we modify policies (Hydra currently modifies a policy by deleting and recreating it), we'll get a bunch of policy records in those tables and we wouldn't know which record we'd get.

@aeneasr aeneasr added this to the 0.7.0: Stability improvements milestone Dec 20, 2016
@aeneasr
Copy link
Member

aeneasr commented Dec 20, 2016

see 070520d

@aeneasr aeneasr changed the title Issue on SQL impl: Deleting policies does not delete associated records sql: deleting policies does not delete associated records Dec 26, 2016
@aeneasr aeneasr changed the title sql: deleting policies does not delete associated records sql: deleting policies does not delete associated records with mysql driver Dec 26, 2016
@aeneasr aeneasr mentioned this issue Dec 26, 2016
Merged
@aeneasr
Copy link
Member

aeneasr commented Dec 31, 2016

resolved by #329

@aeneasr aeneasr closed this as completed Dec 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is not working.
Projects
None yet
Milestone
0.7.0: Stability improvements
Development

No branches or pull requests
2 participants
@johnwu96822 @aeneasr