Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add v2 suffix #3340

Merged
merged 1 commit into from
Nov 5, 2022
Merged

fix: add v2 suffix #3340

merged 1 commit into from
Nov 5, 2022

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Nov 5, 2022

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr self-assigned this Nov 5, 2022
@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Merging #3340 (88c548c) into master (6184b6a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3340   +/-   ##
=======================================
  Coverage   76.86%   76.86%           
=======================================
  Files         123      123           
  Lines        8922     8922           
=======================================
  Hits         6858     6858           
  Misses       1637     1637           
  Partials      427      427           
Impacted Files Coverage Δ
cmd/cliclient/client.go 42.85% <ø> (ø)
cmd/cmd_create_jwks.go 80.00% <ø> (ø)
cmd/cmd_get_client.go 83.33% <ø> (ø)
cmd/cmd_helper_client.go 100.00% <ø> (ø)
cmd/cmd_import_client.go 73.07% <ø> (ø)
cmd/cmd_import_jwk.go 67.53% <ø> (ø)
cmd/cmd_revoke_token.go 86.20% <ø> (ø)
cmd/output_client.go 13.33% <ø> (ø)
cmd/output_introspection.go 9.09% <ø> (ø)
cmd/output_jwks.go 14.81% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr merged commit c54b9db into master Nov 5, 2022
@aeneasr aeneasr deleted the v2-sdk branch November 5, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant