Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --skip-consent flag to hydra cli #3492

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

matt-potter
Copy link
Contributor

Skip consent feature was released in v2.1.0, but is missing as an available flag in the CLI.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@matt-potter matt-potter requested a review from aeneasr as a code owner April 16, 2023 09:11
@CLAassistant
Copy link

CLAassistant commented Apr 16, 2023

CLA assistant check
All committers have signed the CLA.

@matt-potter matt-potter force-pushed the add-skip-consent-cli branch from b60a28d to c7292d7 Compare April 16, 2023 09:17
@matt-potter matt-potter changed the title Add --skip-consent flag to hydra cli feat: add --skip-consent flag to hydra cli Apr 16, 2023
@codecov
Copy link

codecov bot commented Apr 16, 2023

Codecov Report

Merging #3492 (b81023e) into master (6efae7c) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head b81023e differs from pull request most recent head c7292d7. Consider uploading reports for the commit c7292d7 to get more accurate results

@@            Coverage Diff             @@
##           master    #3492      +/-   ##
==========================================
- Coverage   76.86%   76.85%   -0.02%     
==========================================
  Files         124      124              
  Lines        9173     9175       +2     
==========================================
  Hits         7051     7051              
- Misses       1673     1674       +1     
- Partials      449      450       +1     
Impacted Files Coverage Δ
cmd/cmd_create_client.go 72.72% <ø> (ø)
cmd/cmd_helper_client.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 🎉 Your contribution makes Ory better :)

@aeneasr aeneasr merged commit 083d518 into ory:master Apr 17, 2023
@vinckr
Copy link
Member

vinckr commented Apr 20, 2023

Hello @matt-potter
Congrats on merging your first PR in Ory 🎉 !
Your contribution will soon be helping secure millions of identities around the globe 🌏.
As a small token of appreciation we send our first time contributors a gift package to welcome them to the community.
Please drop me an email and I will forward you the form to claim your Ory swag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants