Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: racy random string generation #3555

Merged
merged 1 commit into from
Jun 22, 2023
Merged

fix: racy random string generation #3555

merged 1 commit into from
Jun 22, 2023

Conversation

alnr
Copy link
Contributor

@alnr alnr commented Jun 22, 2023

An obsolete dependency had an illegal concurrent use of "math/rand".Source: https://github.com/gobuffalo/x/blob/913e47c59ca77a753fc68c0daa04b8924b67d7ad/randx/string.go#L17

Removed in favor of a UUID.

@alnr alnr requested a review from aeneasr as a code owner June 22, 2023 15:45
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #3555 (9f916dc) into master (116c1e8) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 9f916dc differs from pull request most recent head 5185c6c. Consider uploading reports for the commit 5185c6c to get more accurate results

@@            Coverage Diff             @@
##           master    #3555      +/-   ##
==========================================
- Coverage   76.64%   76.62%   -0.03%     
==========================================
  Files         129      129              
  Lines        9630     9630              
==========================================
- Hits         7381     7379       -2     
- Misses       1748     1749       +1     
- Partials      501      502       +1     
Impacted Files Coverage Δ
persistence/sql/persister.go 85.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@alnr alnr merged commit 1b26c4c into master Jun 22, 2023
@alnr alnr deleted the racy-rand branch June 22, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants