Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to specify additional SQL migrations #3587

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

alnr
Copy link
Contributor

@alnr alnr commented Jul 31, 2023

No description provided.

@alnr alnr self-assigned this Jul 31, 2023
@alnr alnr requested a review from aeneasr as a code owner July 31, 2023 14:18
driver/factory.go Outdated Show resolved Hide resolved
@alnr alnr force-pushed the extra-migrations branch 3 times, most recently from 92b0f11 to a339099 Compare August 1, 2023 13:21
@alnr alnr changed the title feat: refactor driver configuration and add option to specify additional SQL migrations feat: add option to specify additional SQL migrations Aug 1, 2023
go.mod Outdated Show resolved Hide resolved
cmd/migrate_status.go Show resolved Hide resolved
@alnr alnr force-pushed the extra-migrations branch from a339099 to 70b9658 Compare August 3, 2023 08:49
@alnr alnr force-pushed the extra-migrations branch from 70b9658 to 7544d95 Compare August 3, 2023 08:51
@alnr alnr requested a review from zepatrik August 3, 2023 09:15
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #3587 (7b6845f) into master (749eb8d) will decrease coverage by 0.04%.
Report is 1 commits behind head on master.
The diff coverage is 45.83%.

❗ Current head 7b6845f differs from pull request most recent head 7544d95. Consider uploading reports for the commit 7544d95 to get more accurate results

@@            Coverage Diff             @@
##           master    #3587      +/-   ##
==========================================
- Coverage   76.41%   76.38%   -0.04%     
==========================================
  Files         130      130              
  Lines        9714     9721       +7     
==========================================
+ Hits         7423     7425       +2     
- Misses       1792     1796       +4     
- Partials      499      500       +1     
Files Changed Coverage Δ
driver/factory.go 50.87% <0.00%> (-2.83%) ⬇️
driver/registry.go 23.52% <0.00%> (ø)
cmd/cli/handler_migrate.go 2.19% <41.66%> (+1.30%) ⬆️
cmd/cli/handler.go 100.00% <100.00%> (ø)
cmd/migrate_status.go 100.00% <100.00%> (ø)
driver/registry_sql.go 74.73% <100.00%> (ø)
persistence/sql/persister.go 85.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@aeneasr aeneasr merged commit 8900cbb into master Aug 3, 2023
@aeneasr aeneasr deleted the extra-migrations branch August 3, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants