Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persistence/sql: fix dropped errors #3670

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

alrs
Copy link
Contributor

@alrs alrs commented Nov 22, 2023

This fixes three dropped test err variables in the persistence/sql package.

Signed-off-by: Lars Lehtonen <lars.lehtonen@gmail.com>
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f41949) 75.92% compared to head (07a65d8) 75.87%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3670      +/-   ##
==========================================
- Coverage   75.92%   75.87%   -0.05%     
==========================================
  Files         134      134              
  Lines       10075    10075              
==========================================
- Hits         7649     7644       -5     
- Misses       1910     1914       +4     
- Partials      516      517       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hperl hperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks for your contribution!

@aeneasr aeneasr merged commit 22f0119 into ory:master Dec 13, 2023
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants