Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expired Login/Consent Challenge Should be Resolvable for Consent App #3772

Open
4 of 5 tasks
terev opened this issue May 28, 2024 · 0 comments · May be fixed by #3802
Open
4 of 5 tasks

Expired Login/Consent Challenge Should be Resolvable for Consent App #3772

terev opened this issue May 28, 2024 · 0 comments · May be fixed by #3802
Labels
feat New feature or request.

Comments

@terev
Copy link
Contributor

terev commented May 28, 2024

Preflight checklist

Ory Network Project

No response

Describe your problem

When a login or consent challenge expires Hydra returns a HTTP 401 with an error indicating the expiry. However this makes it hard for the consent app to resolve the error state. This issue will mostly arise when the user has requested a login form which embeds the login challenge, and they leave the form open until the challenge has expired. This is hard for the consent app to resolve as it can no longer view the login request at this point.

Describe your ideal solution

Ideally Hydra would return a HTTP 410 and include where the consent app should redirect to in order to resolve this error state. Like how hydra responds for handled challenges. #2057 (comment)

Workarounds or alternatives

Was able to somewhat work around this by extracting the request url and return it as a hidden field in the login form. Then on login form submission I match the expired challenge errors, and redirect to the request url to restart the flow.

Version

2.2.0

Additional Context

No response

@terev terev added the feat New feature or request. label May 28, 2024
@terev terev linked a pull request Jul 21, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant