Unable to set Public flag to false

[mfzl]

If a client is created with Public flag set to true, client managers are not able to update the flag to false. This is because of how mergo works.

package main

import (
	"fmt"

	"github.com/imdario/mergo"
)

type Client struct {
	Public bool
}

func main() {

	// Client with updated information,
	// wanting to set Public flag to false
	c := &Client{
		Public: false,
	}

	// Client in database with Public flag set to true
	o := &Client{
		Public: true,
	}

	// "Mergo is intended to assign only zero value fields on destination with source value."
	// mergo.Merge(dst, src)
	mergo.Merge(c, o)
	// Because c (the destination) contains false it is considered a zero value
	// and gets replaced by the value of o (the source)

	fmt.Printf("c %+v\n", c)
	fmt.Printf("o %+v\n", o)
}

[mfzl]

I can't think of a simple way to fix without resorting to *bool. Another way would be to inspect the JSON payload with any json query package and check if value was sent by the user. But then we would need to pass around the fact that Public flag was set or not.

[aeneasr]

Hm yeah, actually I think that the PUT command should have the full payload and not mergo at all. What do you think?

[mfzl]

SGTM, that is more inline with the semantics of PUT. One downside would be backwards compatibility, I can't think of anything else.

[aeneasr]

I think that's ok, we'll add it to the release notes

[aeneasr]

@faxal would you mind creating a PR for that? Should be straight forward :)

[mfzl]

Done #478