Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of DB_HOST, DB_PASS, DB_USER, DB_NAME separately. #480

Closed
kminehart opened this issue Jun 2, 2017 · 4 comments
Closed

Comments

@kminehart
Copy link
Contributor

We're having an issue with the helm chart right now, https://github.com/kubernetes/charts/pull/1022/files#r119681171

With Kubernetes, ideally passwords would be stored as secrets. The problem with using the database URL as the only configurable option means the database password has to be stored in Kubernetes as a value in the deployment, rather than as a secret to be encrypted.*

  • yes I know Kubernetes secrets are in plain text at the moment. That won't be the case forever.
@meyerzinn
Copy link

@kminehart I don't see why this couldn't be done with the URL right now. If you set these as secrets, then you can interpolate them into the URL (i.e. DATABASE_URL=postgres://${DB_USER}:${DB_PASS}...). If the secrets are added as environmental variables, they could in turn be used to configure another environmental variable.

@aeneasr
Copy link
Member

aeneasr commented Jun 4, 2017

I agree with @20zinnm

@meyerzinn
Copy link

@arekkas I would consider this closed.

@kminehart
Copy link
Contributor Author

That's true, I had not considered that. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants