Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/postgres: wherever limit/offset is used, include ORDER BY clause #619

Closed
aeneasr opened this issue Oct 18, 2017 · 4 comments
Closed

sql/postgres: wherever limit/offset is used, include ORDER BY clause #619

aeneasr opened this issue Oct 18, 2017 · 4 comments
Labels
bug Something is not working.

Comments

@aeneasr
Copy link
Member

aeneasr commented Oct 18, 2017

See #612 (comment)
@aeneasr aeneasr added bug Something is not working. hacktoberfest labels Oct 18, 2017
@blockloop
Copy link

blockloop commented Oct 18, 2017 •
edited
Loading

I can look into this

@aeneasr
Copy link
Member Author

aeneasr commented Oct 19, 2017

Nice! If you need help feel free to ask!

@zerodivisi0n
Copy link

I can't find any queries with limit/offset in hydra project in master and v0.9.x branches. However, I found one in dependent ladon project there: manager_sql.go. Does it require the fix?

@aeneasr
Copy link
Member Author

aeneasr commented Oct 31, 2017

Nice! Yes, that should definitely be updated there!

@zerodivisi0n zerodivisi0n mentioned this issue Nov 5, 2017
Merged
@aeneasr aeneasr closed this as completed Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is not working.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zerodivisi0n @blockloop @aeneasr