Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation vague regarding returned client_secret #620

Closed
abusaidm opened this issue Oct 18, 2017 · 4 comments
Closed

documentation vague regarding returned client_secret #620

abusaidm opened this issue Oct 18, 2017 · 4 comments

Comments

@abusaidm
Copy link
Contributor

documentation state that when you update client details using PUT /clients/id and you provide client_secret, the secret will be returned just this once. but I noticed that the secret is not returned and that a hashed form of the secret is returned.

If you pass client_secret the secret will be updated and returned via the API. This is the only time you will be able to retrieve the client secret, so write it down and keep it safe.

@aeneasr
Copy link
Member

aeneasr commented Oct 18, 2017

Thank you, this should be fixed with 0.10.x however, are you on 0.9.x?

@abusaidm
Copy link
Contributor Author

I am seeing this on the docs http://docs.hydra13.apiary.io/#reference/oauth2/clientsid/update-an-oauth-2.0-client

I don't know what version this is!

@aeneasr
Copy link
Member

aeneasr commented Oct 18, 2017

The docs always match latest master, so it's version 0.10.x. What I meant is that you are probably running a hydra version below 0.10.x which is why you see the issue you describe. This is the patch that fixed this:

96df498

@abusaidm
Copy link
Contributor Author

ah I see, thank you. I thought you are referring to the docs version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants