Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

policies: change effect type from string to boolean #666

Closed
zepatrik opened this issue Nov 28, 2017 · 1 comment
Closed

policies: change effect type from string to boolean #666

zepatrik opened this issue Nov 28, 2017 · 1 comment
Milestone
unplanned

Comments

@zepatrik
Copy link
Member

Because there are only allow and deny allowed, a boolean should be used.
@aeneasr aeneasr added the feat New feature or request. label Dec 4, 2017
@aeneasr aeneasr added this to the unplanned milestone Dec 4, 2017
@aeneasr
Copy link
Member

aeneasr commented Dec 8, 2017

This actually mirrors the behaviour of AWS IAM policies. Since it's a huge breaking change and would require a lot of manual work I think it's safe to keep this as is for now. Let me know if anyone disagrees.

@aeneasr aeneasr added nofix and removed feat New feature or request. labels Dec 8, 2017
@aeneasr aeneasr removed this from the unplanned milestone Dec 8, 2017
@aeneasr aeneasr added this to the unplanned milestone Jan 15, 2018
@aeneasr aeneasr closed this as completed Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
unplanned
Development

No branches or pull requests
2 participants
@aeneasr @zepatrik