-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Could not fetch signing key for OpenID Connect" #816
Comments
The system secret must be 32 chars long, it says that in the logs too:
```
level=warning msg="Expected system secret to be at least 32 characters long, got 4 characters."
```
|
How about hashing whatever is provided by the user instead of generating a random one so that at least if the user provides one, it'll always be the same? |
Hashing a password does not make it secure. Why should we encourage behaviour that compromises security? |
How is simply requiring a 32 character string secure? I could just do:
A hashed 32 character password is as good as any 32 character password and far better than a pattern-based 32 character password like i provided above. Someone attempting to crack the hashed 32-character password won't know to try hashes of shorter passwords. Also, FYI, when someone is testing out a tutorial, many times they jump straight to the code and only skim the details. |
Please read https://en.wikipedia.org/wiki/Password_strength#Guidelines_for_strong_passwords
Of course, the technology is open source. |
In any case, I think your question has been answered. To avoid the error, please use a password of 32 characters. We will not change the way passwords are used in hydra because besides painful breaking changes we're applying best practice cryptography and there is little reason to allow shorter passwords. |
I'm well aware of security concerns with and comparisons of hashes. My point is that in a tutorial, it's not critical and user experience should matter. |
In that context, it makes way more sense! We could probably die if the secret is to short. This should avoid confusion when starting with the software and is now tracked as #817. Thank you for your suggestion! |
I can't reopen #439 but this is the same problem.
I shut down the container and trying to rerun fails. The problem does indeed appear to be the
SYSTEM_SECRET
but it's because it's not being respected from the command-line.The documented command does not seem to pass that
SYSTEM_SECRET
.Notice that the logs show
"Generating a random system secret..."
and this happened during the first run so it's actually impossible to restart the server.If i delete the tables and run migrate again, it works again though the secret is still randomly generated.
The text was updated successfully, but these errors were encountered: