Add ServiceMonitor ( prometheus-operator ) to charts

[koushki]

We are using prometheus-operator in our k8s clusters to manage Prometheus instances, it seems Ory charts are missing servicemonitor CDR. would be nice if we have ServiceMonitor CDR.

Describe the solution you'd like

Add a ServiceMonitor CDR to charts, this can be implemented similarly to mongodb

Describe alternatives you've considered

We are creating a custom chart that has Hydra as a dependency and a ServiceMonitor CDR.

In case we agree on having ServiceMonitor in ory charts I'm happy to implement it.

[aeneasr]

Hm, I would like to avoid having a lot of templates for different integrations in the helm stack for ORY services. Is there another way to solve this?

[koushki]

I see your point, but this is actually a very popular way of using Prometheus in k8s. lots of stable charts are already using ServiceMonitor, you can check them out here.

The workaround for that is adding a custom helm chart and use for example Hydra helm chart as a dependency. this custom chart has ServiceMonitor CDR template, and we have to use Hydra values for example for labels, label selectors and etc . I would say it works but looks like lots of unnecessary stuff.

[aeneasr]

I see - @tricky42 what is your opinion on this?

[tricky42]

I think this would be great. In general I understand your concern @aeneasr that we shouldn't add every possible integration into the Helm chart. In case of metrics Prometheus is the only open source solution and by now the defacto standard, therefore I think this would be a nice feature for the Helm chart.

@koushki it would be great if you would implement this.

[aeneasr]

Cool, let's go! :)

[deshetti]

@aeneasr sorry to repeat the similar question I asked earlier on slack. I was in fact trying to implement servicemonitor for Kratos and is why I was asking this question: https://ory-community.slack.com/archives/C012RJ2MQ1H/p1610551627242600

I don't mind implementing the service monitor templates and submitting the PRs. What I would like to know is what services expose Prometheus metrics and on what ports.

[aeneasr]

Thank you @deshetti - sorry - I often fail to check slack because there is already so much happening on GH!

Prometheus is already enabled, the URK is: http(s)://kratos-admin:port/metrics/prometheus. If you run the quickstart, it is: http://localhost:4434/metrics/prometheus

[github-actions]

I am marking this issue as stale as it has not received any engagement from the community or maintainers in over half a year. That does not imply that the issue has no merit! If you feel strongly about this issue

• open a PR referencing and resolving the issue;
• leave a comment on it and discuss ideas how you could contribute towards resolving it;
• open a new issue with updated details and a plan on resolving the issue.

We are cleaning up issues every now and then, primarily to keep the 4000+ issues in our backlog in check and to prevent maintainer burnout. Burnout in open source maintainership is a widespread and serious issue. It can lead to severe personal and health issues as well as enabling catastrophic attack vectors.

Thank you for your understanding and to anyone who participated in the issue! 🙏✌️

If you feel strongly about this issues and have ideas on resolving it, please comment. Otherwise it will be closed in 30 days!