-
-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make docker on master (inexistent docker alpine version) #2390
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2390 +/- ##
==========================================
- Coverage 76.61% 76.60% -0.02%
==========================================
Files 315 315
Lines 17320 17320
==========================================
- Hits 13270 13268 -2
- Misses 3118 3119 +1
- Partials 932 933 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for breaking this, was completely my fault.
Co-authored-by: Patrik <zepatrik@users.noreply.github.com>
Co-authored-by: Patrik <zepatrik@users.noreply.github.com>
I see the problem better now. Docker tags are really confusing sometimes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
Co-authored-by: Patrik <zepatrik@users.noreply.github.com>
Currently when executing
make docker
on master, I get the following errors:This is consistent with the fact that the tag doesn't exist on DockerHub.
The easy fix is to simply change the docker alpine version from 3.15.4 to 3.15.
Related issue(s)
None
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.