Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SelfService/Strategy/oidc): rework auth session expiry #242

Merged
merged 4 commits into from
Feb 11, 2020
Merged

fix(SelfService/Strategy/oidc): rework auth session expiry #242

merged 4 commits into from
Feb 11, 2020

Conversation

zepatrik
Copy link
Member

Related issue

closes #233

Proposed changes

Checklist

  • I have read the contributing guidelines
  • I have read the security policy
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

Further comments

@zepatrik zepatrik requested a review from aeneasr February 11, 2020 14:01
@aeneasr aeneasr merged commit 4421e6b into master Feb 11, 2020
@zepatrik zepatrik deleted the ss-registration-oidc-expiry branch March 23, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr Awaiting requested review from aeneasr aeneasr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make OIDC strategy capable of dealing with expiry errors
2 participants
@zepatrik @aeneasr