refactor(persistence/sql): move connection to context to enable transactions #254

zepatrik · 2020-02-17T17:19:22Z

Related issue

I have read the contributing guidelines
I have read the security policy
I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
vulnerability, I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation within the code base (if appropriate)
I have documented my changes in the developer guide (if appropriate)

aeneasr · 2020-02-17T17:54:22Z

persistence/sql/persister_test.go

@@ -146,3 +153,53 @@ func TestPersister(t *testing.T) {
 		t.Logf("DSN: %s", dsn)
 	}
 }
+
+func getErr(args ...interface{}) error {


Wow this is actually really useful. We should probably add that to ory/x!

persistence/sql/persister_test.go

u

3e33b53

zepatrik requested a review from aeneasr February 17, 2020 17:19

aeneasr reviewed Feb 17, 2020

View reviewed changes

persistence/sql/persister_test.go Show resolved Hide resolved

Apply suggestions from code review

063b9c2

aeneasr merged commit 6ace1ee into master Feb 17, 2020

zepatrik deleted the add-persister-transactions branch February 18, 2020 11:20