-
-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add support for verified Graph API calls for facebook oidc provider #2547
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2547 +/- ##
==========================================
+ Coverage 76.31% 76.59% +0.28%
==========================================
Files 321 321
Lines 17954 17960 +6
==========================================
+ Hits 13701 13756 +55
+ Misses 3308 3252 -56
- Partials 945 952 +7
Continue to review full report at Codecov.
|
I'll try to add some tests for facebook provider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you! 🎉 Your contribution makes Ory better :)
Hello @sayoun |
…der (ory#2547) Co-authored-by: aeneasr <3372410+aeneasr@users.noreply.github.com>
Add support to Facebook OIDC provider for verified Graph API calls.
Facebook allow Apps to enable a security flag that requires proof on all API calls as explained in their documentation
Related issue(s)
The current Facebook provider code does not support this flag and the claims retrieval will silently fail with no claims available. When we check the logs returned by the API call made to the Graph API it returns an error of this type
This PR add code to compute the
appsecret_proof
and use it on the Graph API call made to retrieve claims.Checklist
If this pull request addresses a security. vulnerability,
I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.