-
Notifications
You must be signed in to change notification settings - Fork 969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dont reset to false #2965
fix: dont reset to false #2965
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2965 +/- ##
=======================================
Coverage 76.16% 76.16%
=======================================
Files 309 309
Lines 19046 19046
=======================================
Hits 14507 14507
Misses 3414 3414
Partials 1125 1125 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! By the way, you could probably do something similar now with generics a la
import (
"github.com/samber/lo"
"strings"
)
_, found := lo.Find(hook.AllEntries(), func(i HookType) bool {
s, err := v.String()
require.NoErrorf(t, err, "Unexpected Error")
return strings.Contains(s, "The changed identity schema configuration is invalid and could not be loaded.")
})
// ...
default: //nothing
if found {
break
}
}
although they way you wrote it here is more Go-esque than that (and doesn't need a library). Just an alternative way to express this
df95352
to
538cc6d
Compare
Co-authored-by: hackerman <3372410+aeneasr@users.noreply.github.com>
538cc6d
to
88cf3e4
Compare
Addendum to #2964
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments