Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't reuse ports in courier/SMTP tests #3156

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Conversation

alnr
Copy link
Contributor

@alnr alnr commented Mar 9, 2023

No description provided.

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #3156 (137ac94) into master (b6b1679) will decrease coverage by 0.04%.
The diff coverage is 34.61%.

❗ Current head 137ac94 differs from pull request most recent head 526baa9. Consider uploading reports for the commit 526baa9 to get more accurate results

@@            Coverage Diff             @@
##           master    #3156      +/-   ##
==========================================
- Coverage   77.64%   77.60%   -0.04%     
==========================================
  Files         317      317              
  Lines       19992    20009      +17     
==========================================
+ Hits        15522    15528       +6     
- Misses       3278     3290      +12     
+ Partials     1192     1191       -1     
Impacted Files Coverage Δ
x/mailhog.go 5.17% <0.00%> (-1.81%) ⬇️
selfservice/flow/settings/test/persistence.go 100.00% <100.00%> (ø)
session/test/persistence.go 100.00% <0.00%> (+0.94%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@alnr alnr marked this pull request as ready for review March 9, 2023 15:53
@alnr alnr requested review from aeneasr and zepatrik as code owners March 9, 2023 15:53
@aeneasr aeneasr merged commit e260fcf into master Mar 9, 2023
@aeneasr aeneasr deleted the smtp-test-port-forward branch March 9, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants