Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid SQL syntax in ListIdentities #3202

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Conversation

alnr
Copy link
Contributor

@alnr alnr commented Mar 31, 2023

PostgresQL does not support ... WHERE x IN ( ) with an empty argument list. Works in CRDB, though. Our tests didn't catch this because they didn't expand credentials.

Closes #3194

PostgresQL does not support `... WHERE x IN ( )` with an empty argument list.
@alnr alnr requested review from aeneasr and zepatrik as code owners March 31, 2023 09:40
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #3202 (483baf2) into master (3a734c2) will increase coverage by 0.01%.
The diff coverage is 93.33%.

❗ Current head 483baf2 differs from pull request most recent head 96d630f. Consider uploading reports for the commit 96d630f to get more accurate results

@@            Coverage Diff             @@
##           master    #3202      +/-   ##
==========================================
+ Coverage   77.93%   77.95%   +0.01%     
==========================================
  Files         320      320              
  Lines       20410    20427      +17     
==========================================
+ Hits        15907    15923      +16     
  Misses       3301     3301              
- Partials     1202     1203       +1     
Impacted Files Coverage Δ
selfservice/strategy/password/validator.go 91.30% <77.77%> (-1.80%) ⬇️
request/builder.go 72.72% <93.75%> (ø)
driver/config/config.go 82.89% <100.00%> (+0.02%) ⬆️
identity/test/pool.go 100.00% <100.00%> (ø)
persistence/sql/identity/persister_identity.go 80.11% <100.00%> (+0.07%) ⬆️
selfservice/hook/web_hook.go 79.47% <100.00%> (+0.77%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zepatrik zepatrik merged commit 162ab9b into master Mar 31, 2023
@zepatrik zepatrik deleted the fix-list-identities branch March 31, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetching non-existing identities by email or username results in a server error
3 participants