Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow customization of JOIN predicate in QueryForCredentials #3253

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

alnr
Copy link
Contributor

@alnr alnr commented Apr 25, 2023

@alnr alnr self-assigned this Apr 25, 2023
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #3253 (a0aea3e) into master (a17bcb8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head a0aea3e differs from pull request most recent head c3ae16f. Consider uploading reports for the commit c3ae16f to get more accurate results

@@            Coverage Diff             @@
##           master    #3253      +/-   ##
==========================================
+ Coverage   77.88%   77.90%   +0.01%     
==========================================
  Files         320      320              
  Lines       20474    20473       -1     
==========================================
+ Hits        15946    15949       +3     
+ Misses       3327     3325       -2     
+ Partials     1201     1199       -2     
Impacted Files Coverage Δ
persistence/sql/identity/persister_identity.go 80.07% <100.00%> (-0.04%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@alnr alnr marked this pull request as ready for review April 25, 2023 11:59
@alnr alnr enabled auto-merge (squash) April 25, 2023 14:59
@alnr alnr merged commit 8785166 into master Apr 26, 2023
@alnr alnr deleted the credentials-join branch April 26, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants