Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser+JSON flow feature parity with Browser+HTML flow #3287

Closed
6 tasks done
hperl opened this issue May 19, 2023 · 1 comment
Closed
6 tasks done

Browser+JSON flow feature parity with Browser+HTML flow #3287

hperl opened this issue May 19, 2023 · 1 comment
Assignees
Labels
feat New feature or request.

Comments

@hperl
Copy link
Contributor

hperl commented May 19, 2023

Preflight checklist

Describe your problem

Using the browser+JSON flows (i.e., browser API + accept JSON) is currently lacking a couple of features:

  • After a successful OIDC login the response does not contain the correct callback URL to follow up with the consent. Draft PR here: fix: accept OIDC login request in browser+JSON login flow #3271
  • The value of the ory_kratos_continuity cookie is not returned as part of the JSON response when submitting a login/registraton flow.

Describe your ideal solution

Implement the missing features.

Workarounds or alternatives

User Browser+HTML flow

Version

master

Additional Context

No response

@hperl hperl added the feat New feature or request. label May 19, 2023
@hperl hperl self-assigned this May 19, 2023
@BrandonNoad
Copy link
Contributor

BrandonNoad commented May 23, 2023

I wanted to add a bit more context.

After a successful OIDC login the response does not contain the correct callback URL to follow up with the consent. Draft PR here: #3271

In the scenario above, the user is signing in to a third-party service and Ory is acting as the OAuth/OIDC provider.

The value of the ory_kratos_continuity cookie is not returned as part of the JSON response when submitting a login/registraton flow.

In the scenario above, the user is using Ory's "Social Sign-In" feature to sign in to the application. Ory is acting as the OAuth/OIDC client.

The two scenarios could also be combined together in a single flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request.
Projects
None yet
Development

No branches or pull requests

2 participants