-
Notifications
You must be signed in to change notification settings - Fork 969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: db index and duplicate credentials error #3896
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor thing regarding migration
...rations/sql/20240425095000000000_identity_credentials_fix_user_handle_index.cockroach.up.sql
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3896 +/- ##
==========================================
+ Coverage 78.01% 78.06% +0.04%
==========================================
Files 360 360
Lines 25257 25276 +19
==========================================
+ Hits 19705 19732 +27
+ Misses 4041 4034 -7
+ Partials 1511 1510 -1 ☔ View full report in Codecov by Sentry. |
This fixes two minor bugs
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments