Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use a refresh login flow to invoke a prompt=consent OIDC refresh #3956

Closed
5 tasks done
aran opened this issue Jun 17, 2024 · 1 comment
Closed
5 tasks done
Labels
bug Something is not working.

Comments

@aran
Copy link

aran commented Jun 17, 2024

Preflight checklist

Ory Network Project

No response

Describe the bug

If sending {"upstream_parameters": {"prompt": "consent"}} in a login flow with refresh=true, "prompt":"login" is nevertheless in the generated link.

This appears to be because of the IsForced condition:

func (f *Flow) IsForced() bool {

options = append(options, oauth2.SetAuthURLParam("prompt", "login"))

Reproducing the bug

  1. Create a login flow with refresh: true
  2. Submit the login flow with Google OIDC provider, and json encoding of {"upstream_parameters": {"prompt": "consent"}}
  3. Expect to enter a consent OIDC flow, actual is a login OIDC flow.

Relevant log output

No response

Relevant configuration

No response

Version

1.20

On which operating system are you observing this issue?

None

In which environment are you deploying?

None

Additional Context

No response

@aran aran added the bug Something is not working. label Jun 17, 2024
@aeneasr
Copy link
Member

aeneasr commented Sep 20, 2024

This is expected behavior. You should not be able to make decisions on whether Google should show the login form or not as a user. Only Kratos can make that decision.

@aeneasr aeneasr closed this as completed Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

No branches or pull requests

2 participants