Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: text errors to text messages #476

Merged
merged 10 commits into from
Jun 6, 2020
Merged

refactor: text errors to text messages #476

merged 10 commits into from
Jun 6, 2020

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Jun 5, 2020

Closes #428

  • Refactor errors -> messages
  • Write docs for messages

Additional context

BREAKING CHANGES:

Flows, request methods, form fields have had a key errors to show e.g. validation errors such as ("not an email address", "incorrect username/password", and so on. The error key is now however called messages. Each message now has a type which can be error or info, an id which can be used to translate messages, a text (which was previously errors[*].message) and This affects all login, request, settings, and recovery flows and methods.

@aeneasr aeneasr added this to the v0.4.0-alpha.1 milestone Jun 5, 2020
@aeneasr aeneasr self-assigned this Jun 5, 2020
@aeneasr aeneasr marked this pull request as ready for review June 5, 2020 14:17
aeneasr added a commit to ory/kratos-selfservice-ui-node that referenced this pull request Jun 6, 2020
aeneasr added a commit to ory/kratos-selfservice-ui-node that referenced this pull request Jun 6, 2020
@aeneasr aeneasr merged commit 8106951 into master Jun 6, 2020
@aeneasr aeneasr deleted the fix-468 branch June 6, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant