Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CSRF token is required when using the Revoke Session API endpoint #839

Merged
merged 1 commit into from
Nov 23, 2020
Merged

fix: CSRF token is required when using the Revoke Session API endpoint #839

merged 1 commit into from
Nov 23, 2020

Conversation

dbhobbs
Copy link
Contributor

@dbhobbs dbhobbs commented Nov 19, 2020 •
edited
Loading

Related issue

#838

Proposed changes

Exempt the Revoke Session endpoint from requiring a CSRF token.

Checklist

  • I have read the contributing guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further comments

I followed the example of the RouteWhoami CSRF exemption in session/handler.go.

My go skills need some work, so any recommendations on tests or whatever would be welcome. 😄

@CLAassistant
Copy link

CLAassistant commented Nov 19, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dbhobbs dbhobbs changed the title exempt session revoke endpoint from CSRF requirement fix: CSRF token is required when using the Revoke Session API endpoint Nov 19, 2020
aeneasr
aeneasr approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉

Thank you for your contribution!

@aeneasr aeneasr merged commit d3218a0 into ory:master Nov 23, 2020
@aeneasr aeneasr added the corp/m4 Up for M4 at Ory Corp. label Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr aeneasr approved these changes

Assignees
No one assigned
Labels
corp/m4 Up for M4 at Ory Corp.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbhobbs @CLAassistant @aeneasr