Import identities documentation improvements #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
vinckr
reviewed
Jan 19, 2021
cmd/identities/import.go
Outdated
| { | ||
| "schema_id": "default", | ||
| "traits": { | ||
| "email": "foo@ory.sh" |
There was a problem hiding this comment.
Suggested change
| "email": "foo@ory.sh" | |
| "email": "foo@example.com" |
Maybe example.com is better, dont want to get spammed on ory.sh ;).
There was a problem hiding this comment.
Yeah sure changed it now!
vinckr
approved these changes
Jan 19, 2021
aeneasr
requested changes
Jan 19, 2021
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
No related issue
Proposed changes
The import identities command documentation was hard to understand since there were no example credential files. There were also no references to the import identities command in the managing user identities documentation.
Checklist
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.