-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFE: Automatically set nodatacow on $pooldir when on btrfs #4679
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This Pull Request has been automatically closed as it did not have any activity in the last 97 days. Thank you. |
Reopening as likely still valid. Also I created https://progress.opensuse.org/issues/117136 to prevent the stale bot to close issues which are still valid. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
It doesn't look like this worked. At least this issue was still marked as stale. 🤔 |
yes, but the PR is only marked as stale, not closed. That's what we wanted. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Summary: Btrfs upstream advises VM images use nodatacow, therefore make sure
chattr +C
is set on the openqa directory (at create time).Background: On (open)SUSE,
/var
has nodatacow file attributeC
set at installation time. But most other distros don't do this, including Fedora. Meanwhile, libvirt now checks if a dir pool is on btrfs and by default sets the nodatacow file attribute.https://listman.redhat.com/archives/libvir-list/2020-July/205982.html
Since libvirt isn't being used here, I think it's reasonable to just unconditionally set nodatacow file attribute on btrfs whenever creating a new parent directory to be used for openqa. Any new dirs and files, including qcow2, will inherit this file attribute.
The text was updated successfully, but these errors were encountered: