Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter warnings #2677

Open
lucasgarfield opened this issue Dec 11, 2024 · 0 comments
Open

Fix linter warnings #2677

lucasgarfield opened this issue Dec 11, 2024 · 0 comments
Labels
🥇 good first issue Good for newcomers

Comments

@lucasgarfield
Copy link
Collaborator

We still have 13 warnings being issued by the linter. Let's get them fixed up and increase the signal to noise ratio:

/home/lgarfiel/image-builder-frontend/src/Components/Blueprints/BlueprintsSideBar.tsx
  178:27  warning  React Hook useCallback received a function whose dependencies are unknown. Pass an inline function instead  react-hooks/exhaustive-deps

/home/lgarfiel/image-builder-frontend/src/Components/Blueprints/ImportBlueprintModal.tsx
  114:6  warning  React Hook React.useEffect has a missing dependency: 'dispatch'. Either include it or remove the dependency array  react-hooks/exhaustive-deps

/home/lgarfiel/image-builder-frontend/src/Components/CreateImageWizard/ImportImageWizard.tsx
  30:6  warning  React Hook useEffect has a missing dependency: 'navigate'. Either include it or remove the dependency array  react-hooks/exhaustive-deps

/home/lgarfiel/image-builder-frontend/src/Components/CreateImageWizard/steps/ImageOutput/TargetEnvironment.tsx
  57:6  warning  React Hook useEffect has a missing dependency: 'prefetchActivationKeys'. Either include it or remove the dependency array  react-hooks/exhaustive-deps

/home/lgarfiel/image-builder-frontend/src/Components/CreateImageWizard/steps/Oscap/Oscap.tsx
  157:6  warning  React Hook useEffect has missing dependencies: 'dispatch', 'policies', 'policyID', and 'policyTitle'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/lgarfiel/image-builder-frontend/src/Components/CreateImageWizard/steps/Oscap/OscapProfileInformation.tsx
  81:6  warning  React Hook useEffect has missing dependencies: 'dispatch' and 'policyInfo'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/lgarfiel/image-builder-frontend/src/Components/CreateImageWizard/steps/Packages/PackageRecommendations.tsx
  109:6  warning  React Hook useEffect has missing dependencies: 'analytics' and 'isBeta'. Either include them or remove the dependency array  react-hooks/exhaustive-deps
  120:6  warning  React Hook useEffect has a missing dependency: 'distroRepoUrls'. Either include it or remove the dependency array            react-hooks/exhaustive-deps

/home/lgarfiel/image-builder-frontend/src/Components/CreateImageWizard/steps/Packages/Packages.tsx
  276:6  warning  React Hook useEffect has a missing dependency: 'debouncedSearchTermIsGroup'. Either include it or remove the dependency array                                                                                          react-hooks/exhaustive-deps
  336:6  warning  React Hook useEffect has missing dependencies: 'arch', 'debouncedSearchTermIsGroup', 'distroRepositories', 'isSuccessDistroRepositories', and 'isSuccessEpelRepo'. Either include them or remove the dependency array  react-hooks/exhaustive-deps
  760:6  warning  React Hook useMemo has an unnecessary dependency: 'debouncedSearchTerm'. Either exclude it or remove the dependency array                                                                                              react-hooks/exhaustive-deps

/home/lgarfiel/image-builder-frontend/src/Components/CreateImageWizard/steps/Registration/ActivationKeysList.tsx
  205:6  warning  React Hook useEffect has missing dependencies: 'activationKey', 'activationKeys', 'createActivationKey', 'defaultActivationKeyName', 'dispatch', 'isLoadingActivationKey', 'recentActivationKey', and 'refetch'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/lgarfiel/image-builder-frontend/src/Components/CreateImageWizard/steps/Registration/Registration.tsx
  114:6  warning  React Hook useEffect has missing dependencies: 'dispatch' and 'distribution'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

✖ 13 problems (0 errors, 13 warnings)```
@lucasgarfield lucasgarfield added the 🥇 good first issue Good for newcomers label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥇 good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant