Skip to content
This repository has been archived by the owner on May 26, 2021. It is now read-only.

LoadError: UndefVarError: vector_space not defined #9

Open
heiderich opened this issue Aug 2, 2019 · 3 comments
Open

LoadError: UndefVarError: vector_space not defined #9

heiderich opened this issue Aug 2, 2019 · 3 comments

Comments

@heiderich
Copy link

in test/ComAlg/ModFld-test.jl:3

@wbhart
Copy link
Contributor

wbhart commented Aug 2, 2019

There is no working code in Oscar.jl. It's not really worth reporting that the tests fail. The tests and all existing code should be removed.

@heiderich
Copy link
Author

The tests and all existing code should be removed.

Can you expand on that? Your comment oscar-system/Oscar.jl#7 (comment) sounds like an encouragement to make tests work.

@wbhart
Copy link
Contributor

wbhart commented Aug 2, 2019

Sure. All tests should be run. This is what people want, and it should be a priority. But we should first remove all tests that don't work, which happens to be all of them.

To my knowledge, the code that is in Oscar.jl at the moment is highly incomplete, has been superceded, has not been maintained and should be removed. On the other hand, the person who wrote it is currently on leave. It's a git repository though, so it's not as if it will be lost if someone deletes it.

At the very least, if you want to get those tests working, you have some months of work ahead of you. I have said before, incomplete code dumps should not be permitted. But that is not a universal opinion.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants