Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning on julia master #864

Closed
thofma opened this issue Apr 27, 2023 · 4 comments · Fixed by #866
Closed

Warning on julia master #864

thofma opened this issue Apr 27, 2023 · 4 comments · Fixed by #866

Comments

@thofma
Copy link
Contributor

thofma commented Apr 27, 2023

I just got

┌ GAP [c863536a-3901-11e9-33e7-d5cd0df7b904]
│  WARNING: could not import REPLCompletions.get_value into GAP

on

julia> versioninfo()
Julia Version 1.10.0-DEV.1128
Commit bc2fa503a8* (2023-04-27 05:52 UTC)
Platform Info:
  OS: macOS (arm64-apple-darwin22.4.0)
  CPU: 8 × Apple M1
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-14.0.6 (ORCJIT, apple-m1)
  Threads: 1 on 4 virtual cores
@ThomasBreuer
Copy link
Member

Thanks for the hint.
Apparently REPL/src/REPLCompletions.jl has changed in version 1.10. There is no get_value anymore. The (undocumented) function complete_symbol mentioned in issue #752 does no longer call get_value (and now takes different arguments).

@fingolfin
Copy link
Member

So we need to add a check that only defines the get_value method in older Julia versions resp. only when it exists.

And perhaps add an alternative that achieves the same thing in newer OSCAR if it is possible...

@fingolfin
Copy link
Member

get_value was removed in this PR JuliaLang/julia#49206, so perhaps studying it will give a hint how to do things now

@fingolfin
Copy link
Member

Should be fixed by #866 -- turns out the fix is that the new code in Julia automatically does the right thing and we can just get rid of our hack. Hooray!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants