Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test which iterates over all (or at least some) tables and verifies that the characters have norm 1? #98

Open
fingolfin opened this issue Jul 24, 2024 · 1 comment
Labels
enhancement New feature or request question Further information is requested testing Additional tests are needed

Comments

@fingolfin
Copy link
Member

@SoongNoonien has some concern that this may be too slow if we do it for all. So this raises a few new questions

  • how long does it take to just load all tables?
  • how long does it take to compute all norms for some specific tables (maybe a small one vs. a "big" one)
  • how long does it really take to compute all norms on all tables?

Besides timings it would also be very interesting to know more about the memory usage (e.g. how many allocations and how many MB/GB/... of RAM are used to e.g. load a single specific table; load all tables; etc.)

When we have some numbers, we can then also use this as an opportunity to look into tuning the code...

@SoongNoonien SoongNoonien added enhancement New feature or request question Further information is requested labels Jul 24, 2024
@SoongNoonien SoongNoonien added the testing Additional tests are needed label Sep 25, 2024
@fingolfin
Copy link
Member Author

Now that we already perform tests for all tables in test/runtests.jl:105 we could start looking into doing this as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested testing Additional tests are needed
Projects
None yet
Development

No branches or pull requests

2 participants