Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track coverage of C++ code, too #224

Open
fingolfin opened this issue Apr 21, 2020 · 1 comment
Open

Track coverage of C++ code, too #224

fingolfin opened this issue Apr 21, 2020 · 1 comment

Comments

@fingolfin
Copy link
Member

It would be good to track coverage of the C++ code in deps/src, too (not just of the Julia code in src). This probably involves convincing the cmake build system to insert --coverage into CXXFLAGS and LDFLAGS used for building libsingularwrap.

@fingolfin
Copy link
Member Author

Now that libsingular sources are back in, we could try to do this. Some thoughts:

  • we can touch deps/src/COVERAGE or something like that to force the treehash for deps/src to differ, and thus for the code there being used instead of the JLL
  • next we need a way to add --coverage to CXXFLAGS and LDFLAGS
  • it may be necessary to invoke gcov or something like that after the test suite did run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant