Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for esbuild plugins #6

Open
rajadain opened this issue Feb 24, 2021 · 2 comments
Open

Support for esbuild plugins #6

rajadain opened this issue Feb 24, 2021 · 2 comments

Comments

@rajadain
Copy link

rajadain commented Feb 24, 2021

Hello,

Thank you for this project, it's very promising!

I'm working on a project has a number of SVG imports, and in the current webpack setup they are imported as SVGR:

import Prev2 from '../img/Prev2.svg';
import Prev from '../img/Prev.svg';
import Next2 from '../img/Next2.svg';
import Next from '../img/Next.svg';

esbuild does not support SVGs natively, however, there is a plugin for this: https://github.com/kazijawad/esbuild-plugin-svgr

Unfortunately, plugins cannot be configured through the esbuild CLI, and must be specified be specified in JavaScript or Go: evanw/esbuild#111 (comment).

Is there a way I could use the SVGR plugin via sørvør?

Thanks!

@osdevisnot
Copy link
Owner

👋 Thank you for kind words @rajadain.

The SVGR plugin is authored and intended to be used with a JS build tools. I want to get to JS only plugins once the go api is flushed out and sorvor is little more stable.

I will keep this issue open to track the efforts and to hear ideas about the integration from anyone interested.

@gunn4r
Copy link

gunn4r commented Jun 29, 2021

+1 for this. We'll fork for now and add to the plugins in go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants