Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template): Solve missing information #151

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

Anavelyz
Copy link
Collaborator

@Anavelyz Anavelyz commented Jul 24, 2023

Pull Request description

  • The missing information was due to wrong variable names in base.yaml and osl.yaml, this is corrected in this PR.
  • Fix a typo in cli.py

Solve #147 #121

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more complexity.
  • New and old tests passed locally.

Reviewer's Checklist

  • I managed to reproduce the problem locally from the main branch
  • I managed to test the new changes locally
  • I confirm that the issues mentioned were fixed/resolved.

@Anavelyz Anavelyz requested a review from xmnlab July 24, 2023 02:25
@xmnlab xmnlab merged commit 8811b22 into osl-incubator:main Jul 24, 2023
@xmnlab
Copy link
Member

xmnlab commented Jul 24, 2023

thanks @Anavelyz !

@github-actions
Copy link

🎉 This PR is included in version 0.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants