Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: no choice to disable mypy #157

Closed
Saransh-cpp opened this issue Jul 27, 2023 · 1 comment · Fixed by #158
Closed

[Bug]: no choice to disable mypy #157

Saransh-cpp opened this issue Jul 27, 2023 · 1 comment · Fixed by #158
Labels

Comments

@Saransh-cpp
Copy link
Member

  • Date you used Cookiecutter Python Package: 26th July 2023
  • Cookieninja version used, if any:
  • Python version, if any: 3.9
  • Operating System: macOS Ventura 13.4

Description

There is no option to "select" mypy in the TUI as mypy is not listed under "multiple-choices" -

choices:
- bandit
- black
- blue
- conda
- coverage
- flake8
- ruff
- isort
- mccabe
- pre-commit
- pydocstyle
- pytest
- hypothesis
- shellcheck
- vulture

hence, mypy is added to the created project by default (as the default answer is "yes" in cookiecutter.json -

"use_mypy": "yes",

There could be 2 fixes here -

  1. We want mypy to always be added, then we can simply get rid of all the use_mypy instances.
  2. We do provide an actual choice.

What should be done here?

What I Did

$ scicookie
@Saransh-cpp Saransh-cpp changed the title There is no choice to disable mypy [Bug]: no choice to disable mypy Jul 27, 2023
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

🎉 This issue has been resolved in version 0.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant