Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move back to cookiecutter #284

Merged
merged 1 commit into from
May 11, 2024

Conversation

xmnlab
Copy link
Member

@xmnlab xmnlab commented May 11, 2024

Pull Request description

How to test these changes

  • ...

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more
    complexity.
  • New and old tests passed locally.

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved

@xmnlab xmnlab marked this pull request as ready for review May 11, 2024 16:13
@xmnlab
Copy link
Member Author

xmnlab commented May 11, 2024

@Saransh-cpp @EverVino @Anavelyz @YurelyCamacho ,
currently scicookie is not working on pipx ... so the plan is to move back to cookiecutter
and as a follow up, move from the sh to cookiecutter api

I am merging this PR now ... but feel free to point any issue here and I will work on that as a follow up

@xmnlab xmnlab merged commit f7cc72a into osl-incubator:main May 11, 2024
13 checks passed
@xmnlab xmnlab deleted the fix-pipx-installation branch May 11, 2024 16:16
Copy link

🎉 This PR is included in version 0.8.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

YurelyCamacho pushed a commit to YurelyCamacho/cookiecutter-python that referenced this pull request Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant