Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write tests for the connections pagination convention #84

Open
evanmcneely opened this issue Jul 19, 2022 · 2 comments
Open

Write tests for the connections pagination convention #84

evanmcneely opened this issue Jul 19, 2022 · 2 comments
Labels
documentation Improvements or additions to documentation testing Requires tests to be created or modified

Comments

@evanmcneely
Copy link
Contributor

Connections are configured to have a field weight of 2 but this is not reflected anywhere in the cost analysis. How should we handle this? Where does this come into play?
@evanmcneely
Copy link
Contributor Author

Connections are a pagination convention, different than slicing arguments. See this paper or screen shots below.

https://github.com/Alan-Cha/fse20/blob/master/submissions/functional/FSE-24/graphql-paper.pdf

Image
Image

@evanmcneely evanmcneely changed the title What are connections? Write tests for the connections pagination convention Jul 31, 2022
@evanmcneely
Copy link
Contributor Author

Connections can be handled with a combination of slicing arguments and directives. Confirm with tests and update documentation

@evanmcneely evanmcneely added documentation Improvements or additions to documentation testing Requires tests to be created or modified labels Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation testing Requires tests to be created or modified
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@evanmcneely