Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"ctx.state._dashport.session" isn't a proper session store #52

Open
reggi opened this issue Sep 2, 2022 · 1 comment
Open

"ctx.state._dashport.session" isn't a proper session store #52

reggi opened this issue Sep 2, 2022 · 1 comment

Comments

@reggi
Copy link

reggi commented Sep 2, 2022

I've been diving deep into the codebase here and trying to figure out how it works. I'm having an issue where every route that I call dashport.authorize(strat, serial, deserial) no matter how many times I authorize github (in my case) I'm still being redirected back to the oauth configured callbak url. This seems because fundamentally each middleware checks for a stored value on the oak context, this is new for every page load, so it will never be set on subsequent calls routes. Even if this check was to check on the dashport's, this._sId this still also doesn't make much sense there's only one dashport instance for the entire server this means if you successfully stored the user session id on this property the next user to login replace the current logged in user. I don't understand how this ever worked? Perhaps there's something I'm missing? Is there a proper session store module that I need to use in junction with this?

@reggi
Copy link
Author

reggi commented Sep 2, 2022

Yeah I think this is the same issue as:
#48
#46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant