Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legend displays intermittent lake or pond with gray fill instead of light blue #664

Closed
zekefarwell opened this issue Jan 4, 2023 · 2 comments · Fixed by #671
Closed
Labels
bug Something isn't working

Comments

@zekefarwell
Copy link
Collaborator

Maybe because the intermittent fill uses a semi-transparent color value?

Screen Shot 2023-01-03 at 8 13 04 PM

https://zelonewolf.github.io/openstreetmap-americana/#map=16.84/-28.073345/153.423839

@zekefarwell zekefarwell added the bug Something isn't working label Jan 4, 2023
@1ec5
Copy link
Member

1ec5 commented Jan 4, 2023

This might be due to some tweak I made after opening #632 or it might be related to #637. The screenshots in #632 (comment) show that it worked at the time I opened the PR.

@1ec5
Copy link
Member

1ec5 commented Jan 7, 2023

The cause seems to be the waterIntermittentFill constant added in #637:

https://github.com/ZeLonewolf/openstreetmap-americana/blob/321e7f69625299aea0d31e79ba89a466ae8845d6/src/constants/color.js#L6

The feature querying result comes back with an evaluated color object where each component is premultiplied by the opacity. The legend code produces rgba(58.199999999999996, 64.8, 72, 0.3) instead of rgba(194, 216, 240, 0.3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants