Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style statistics based on source layer #777

Closed
ZeLonewolf opened this issue Feb 9, 2023 · 2 comments · Fixed by #882
Closed

Style statistics based on source layer #777

ZeLonewolf opened this issue Feb 9, 2023 · 2 comments · Fixed by #882
Labels
enhancement New feature or request

Comments

@ZeLonewolf
Copy link
Member

ZeLonewolf commented Feb 9, 2023

This is a follow-on from #747 to document additional work improve the stats generator.

We could group the layers by source layer to get pretty similar statistics, modulo some layer organization weirdness in OpenMapTiles.

Originally posted by @1ec5 in #747 (comment)

@claysmalley claysmalley added the enhancement New feature or request label Jun 16, 2023
@1ec5
Copy link
Member

1ec5 commented Jun 19, 2023

To implement this enhancement, replace:

let layerGroup = layer.id.split("_", 1)[0];

with:

let layerGroup = layer["source-layer"] || layer.source || layer.type;

and revert the style layer IDs to what they were before #747.

This will help us see not only where the style can be optimized but also where an Americana-specific tile schema could be more optimal than OpenMapTiles.

@ZeLonewolf
Copy link
Member Author

With the suggested change, it sounds like the layer IDs are irrelevant as long as they're distinct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants