Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra option for contour line width doesn't work from custom rendering style in Android version (it works in iOS version) #20501

Open
bobeeeze opened this issue Aug 5, 2024 · 5 comments · May be fixed by #21630
Assignees
Milestone

Comments

@bobeeeze
Copy link
Contributor

bobeeeze commented Aug 5, 2024

Description

We've created a rendering style for hiking in which we want an extra option to appear in the contour line widths. This appears in iOS but not in the Android version. If I make the modification directly in contourlines.addon.render.xml the option appears without any problem in the Android version too. But the intention is to include this option in the rendering style so that it isn't overwritten each time a new version of Osmand is installed.

Translated with DeepL.com (free version)

Steps to reproduce

https://github.com/OsmAnd-Rendering/Hiking/blob/main/Hiking.render.xml
This is the rendering style. Install it and try

Actual result

We don't see the extra option "+" in the contour line width

Expected result

We should see the extra option "+" in the contour line width

Your Environment (required)

Android, osmand+

@yuriiurshuliak
Copy link

Please attach a video or screenshot showing the correct behavior and how it currently looks for you.

@bobeeeze
Copy link
Contributor Author

bobeeeze commented Aug 5, 2024

With the modification in contourlines.addon.render.xml:

With the modification in hiking.render.xml

@bobeeeze
Copy link
Contributor Author

bobeeeze commented Aug 5, 2024

To help you understand, I'd like to point out that if I change the width values for the Thick, Medium and Thin options in the hiking rendering style file, it works fine and the contour lines change thickness according to the values I've entered.

@bobeeeze bobeeeze changed the title Extra option for contour line width doesn't work from rendering style in Android version (it works in iOS version) Extra option for contour line width doesn't work from custom rendering style in Android version (it works in iOS version) Aug 5, 2024
@yuriiurshuliak
Copy link

The bug has been reproduced. To reproduce it, import the custom rendering style Hiking.render.xml. Select it as the main map style, then open Contour Lines and choose the Contour line width option.

On iOS, you'll see the "+" option in list included in the rendering style. On Android, you'll see a standard list without the "+" option.

OsmAnd~ 4.9.0#2909m, released: 2024-08-06
OsmAnd 4.8.0.9

iOS Android

@vshcherb vshcherb added this to the 4.9-android milestone Aug 30, 2024
@vshcherb vshcherb modified the milestones: 4.9-android, 5.0-android Sep 26, 2024
@DmitryAlexei
Copy link
Contributor

DmitryAlexei commented Dec 4, 2024

  • we need to reproduce this issue

@nazar-kutz nazar-kutz self-assigned this Dec 5, 2024
@nazar-kutz nazar-kutz linked a pull request Dec 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants