Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click on Relation POIs: issue with clicks on university POIs #21993

Open
1 of 13 tasks
vshcherb opened this issue Mar 3, 2025 · 0 comments
Open
1 of 13 tasks

Click on Relation POIs: issue with clicks on university POIs #21993

vshcherb opened this issue Mar 3, 2025 · 0 comments
Assignees
Labels
Milestone

Comments

@vshcherb
Copy link
Member

vshcherb commented Mar 3, 2025

Backend - @xmd5a2
https://www.openstreetmap.org/relation/5121502#map=17/50.448606/30.495488

  • Non informative name <string name="poi_landuse_education">Education</string> - Should be "Educational area"
  • education: university [ man_made='education' ]man_made=eductation - non present in poi_types.xml - man_made is category for poi_landuse_education - check binary inspector (wrong output?)
education: university Національний педагогічний університет ім. Михайла Драгоманова Lat 50.448776 Lon 30.495537 osmid=2204267673600  [ man_made='education'  ]  poi_additional:[ official_name='Національний педагогічний університет імені Михайла Петровича Драгоманова' website='https://npu.edu.ua/' opening_hours='Mo-Sa 10:00-20:00' wikipedia='http://uk.wikipedia.org/wiki/Національний педагогічний університет імені М. П. Драгоманова' wikidata='Q4315056'  ]  name:uk='Національний педагогічний університет ім. Михайла Драгоманова'  cities:[name:pt=... ]
man_made: landuse_education Національний педагогічний університет ім. Михайла Драгоманова Lat 50.448776 Lon 30.495537 osmid=2204267673600  [ education='university'  ]  poi_additional:[ official_name='Національний педагогічний університет імені Михайла Петровича Драгоманова' website='https://npu.edu.ua/' opening_hours='Mo-Sa 10:00-20:00' wikipedia='http://uk.wikipedia.org/wiki/Національний педагогічний університет імені М. П. Драгоманова' wikidata='Q4315056'  ]  name:.... ]

Technical solution: Remove old code and create poi for each multipolygon, also include bbox like in route to find other buildings.
Split POIs per outer ring so they could be displayed, each POIs should encode bbox where they should be searched

   if (multipolygons.size() > 1 && "boundary".equals(tags.get(OSMTagKey.TYPE.getValue()))) {
            LatLon center = OsmMapUtils.getCenter(e);
            if (center != null) {
                String url = MapUtils.createShortLinkString(center.getLatitude(), center.getLongitude(), 13);
                tags.put("osmand_poi_lat_lon", url);
            }
        }

Testing procedure: Click on POI layers icons or via search and click on university icons in Android / iOS of https://www.openstreetmap.org/relation/5121502

Web - bug:

  • Doesn't display main category
  • Translation Education / Education doesn't make sense and not present check Android "Man made" education as it's
  • Education category is not displayed and searchable

iOS - bug:

  • Education: education doesn't make sense and doesn't reflect tag / value? Amenity: university probably as object wasn't found
  • Bug that relation close to original object was not found in POI - search radius should be
  • Education category is not searchable correctly (Show on map)
  • Within bug - Missing information on click https://www.openstreetmap.org/relation/31531

Android - bug:

  • Doesn't display name on non searched buildings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants