Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Greyhound bus stations / stops #3164

Closed
tas50 opened this issue Oct 27, 2019 · 5 comments
Closed

Add Greyhound bus stations / stops #3164

tas50 opened this issue Oct 27, 2019 · 5 comments

Comments

@tas50
Copy link
Contributor

tas50 commented Oct 27, 2019

Another super common private bus stop / station that should get into the index.

@1ec5
Copy link
Member

1ec5 commented Oct 27, 2019

Part of #2864.

@tas50
Copy link
Contributor Author

tas50 commented Oct 28, 2019

@1ec5 I thought a good start would be tackling the commercial transit side of things since those are standard brands. These 2 are easy additions.

@1ec5
Copy link
Member

1ec5 commented Oct 28, 2019

In that case, we could reopen and merge #2863. It’s a fine place to start, though as I expressed in #2863 (comment), I do hope we can find a way to add network tags to the picture, given that network is more practical and relevant than brand for this kind of infrastructure.

@bhousel
Copy link
Member

bhousel commented Oct 28, 2019

Ah yeah, this is a thing I've kind of been putting off, sorry..

My rough thinking on this is... if you go to https://nsi.guide, you see this:

Screenshot 2019-10-28 11 42 07

That's because we are treating the brand:wikidata almost as a "natural key" (sort of, but not really, as they aren't unique).
brand:wikidata tag is that important link between OSM and wikidata.

For some other types of features that will be operator:wikidata or network:wikidata or something else maybe.

So we need some way of handling alternate trees for entries to live under. Right now everything is under brands/ and we need to grow beyond that. It changes a lot of stuff about how the project is organized (including code), but will let us do a lot more too.

@bhousel
Copy link
Member

bhousel commented Nov 11, 2020

This was done! There's a transit tree now and Greyhound Lines is in it:
https://nsi.guide/index.html?t=transit&k=route&v=bus&tt=grey#greyhoundlines-1d67e7

@bhousel bhousel closed this as completed Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants