Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue cinemas #3420

Closed
boothym opened this issue Dec 5, 2019 · 7 comments
Closed

Vue cinemas #3420

boothym opened this issue Dec 5, 2019 · 7 comments

Comments

@boothym
Copy link

boothym commented Dec 5, 2019

Normally in iD when you have a plain POI - e.g. with amenity=cinema and name=Vue - iD would prompt you to upgrade the tag if it is present in the NSI.

For Vue Cinemas, if you click in the name field and press space iD offers the UK/Ireland and Netherlands versions.

Can this be fixed in the NSI so that Vue on its own in the UK is recognised as a brand needing to be upgraded? As it seems like the "(IrelandAndUK)" part of the name is causing a problem.

Let me know if this issue should be in the iD github instead.

@bhousel
Copy link
Member

bhousel commented Dec 5, 2019

I think iD will not offer to upgrade names that are ambiguous.
These are names with a ~(something) on the end. Users will need to perform these upgrades manually for now.

@boothym
Copy link
Author

boothym commented Dec 5, 2019

Ok. Would it be possible for iD to compare only the first part of the name (i.e. before the ~)? And then since there is a country code to separate the UK/IRL and Netherlands brands, only one brand will match, which could be offered as an upgrade?

@bhousel
Copy link
Member

bhousel commented Dec 6, 2019

Ok. Would it be possible for iD to compare only the first part of the name (i.e. before the ~)? And then since there is a country code to separate the UK/IRL and Netherlands brands, only one brand will match, which could be offered as an upgrade?

I think sometime in the future, the geometry will be what disambiguates the entries and all the tools that we use will have the ability to know whether a user is editing within that geographical region. iD won't need string disambiguators. But for right now - we use strings because that was the fastest way to get something working that isn't broken.

What makes this problem tricky is:

  • iD's country code awareness only recently (last month) got a boost by integrating the country-coder dataset. Before that, we needed to do nominatim lookups and those are slow.
  • But it's not just limited to country codes.. Even within countries we have brands with the same name operating independently.

A good example of this is "Price Chopper", which has 2 different entries (New York and Kansas City). https://nsi.guide/index.html?k=shop&v=supermarket#Price%20Chopper~(Kansas%20City)
https://overpass-turbo.eu/s/OJZ

Another is "Giant" fuel stations - one is related to a Supermarket (and there are multiple ambiguous Giant supermarkets), another is a southwestern chain that is in the middle of a rebrand to "Marathon" or maybe "Speedway" (see 9e1668a) https://overpass-turbo.eu/s/OK0

@UKChris-osm
Copy link
Collaborator

Could the two Vue entries have the "~(IrelandAndUK)" and "~(Netherlands)" removed, as both have country code references?

I tried placing a random node in the UK, and the Vue suggested was the UK one, and placing a node in the Netherlands resulted in the Netherlands Vue being suggested.

@kymckay
Copy link
Collaborator

kymckay commented Feb 2, 2020

@UKChris-osm: They still need unique keys in the json data which is why we add those.

In theory iD (or any downstream software) could remove that bit of the string when shown to the user, but you'd need to make sure two disambiguated brands are exclusive to regions with no overlap before doing that - which is quite sophisticated to implement for such a small change.

@UKChris-osm
Copy link
Collaborator

Ah I see, I wasn't sure as I saw both entries had the same "Vue" name & brand tag and assumed this meant the same initial value (amenity/cinema|Vue) could appear in multiple entries with different Country Codes.

@bhousel
Copy link
Member

bhousel commented Jul 10, 2020

I think sometime in the future, the geometry will be what disambiguates the entries and all the tools that we use will have the ability to know whether a user is editing within that geographical region.

The work on #2714 (comment) unblocks us to being able to disambiguate the entries by their locationSet geometry instead of a string like "(IrelandAndUK)" .

Closing this issue in favor of #3995, which is the same idea.

@bhousel bhousel closed this as completed Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants