Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chateau d'Ax #4427

Closed
pyrog opened this issue Oct 9, 2020 · 7 comments · Fixed by #4437
Closed

Add Chateau d'Ax #4427

pyrog opened this issue Oct 9, 2020 · 7 comments · Fixed by #4437
Labels
add brand Actionable - add a brand to the index

Comments

@pyrog
Copy link
Contributor

pyrog commented Oct 9, 2020

name=Chateau d'Ax
shop=furniture
website=https://www.chateau-dax.com
website=https://www.chateau-dax.fr
website=https://www.chateau-dax.it
website=https://www.chateau-dax.be
website=https://www.chateau-dax.nl
wikidata=Q100249791

Currently 33 / 59 shops in France https://overpass-turbo.eu/s/YT4

Countries

Angola
Belgium
Canada
China
Croatia
France
Germany
Guadeloupe
Hong Kong
Italy
Malta
Martinique
Mauritius
Morocco
Mozambico
Portogallo
Portugal
Reunion Island
Singapore
Slovacchia
Spain
Switzerland
Taiwan
Tunisia
Turkey
USA
Vietnam
@pyrog pyrog changed the title Add Château d'Ax Add Chateau d'Ax Oct 9, 2020
@Identitaet Identitaet added the add brand Actionable - add a brand to the index label Oct 9, 2020
@joey2031
Copy link
Contributor

Hello, I would like to work on this issue, is that ok?

@Identitaet
Copy link
Collaborator

Yes it's okay

@joey2031
Copy link
Contributor

joey2031 commented Oct 10, 2020

So I finished but I just have some questions:

  1. I can't find a wiki page for this company, do I just take out the "brand:wikipedia"?
  2. Some countries where not on the wiki with the iso codes so I googled them and got this result:
    Mozambico: MZ, Portogallo: PRT, Reunion Island: RE, Taiwan: TWN
      "displayName": "Chateau d'Ax",
      "id": "",
      "locationSet": {"include": ["ao", "be", "ca", "cn", "hr", "fx", "de", "gp", "hk", "it", "mt", "mq", "mu", "ma", "mz", "prt", "pt", "re", "sg", "si", "es", "ch", "twn", "tn", "us", "vn"]},
      "tags":{
        "brand": "Chateau d'Ax",
        "name": "Chateau d'Ax",
        "brand:wikidata": "Q100249791",
        "shop": "furniture"
      }
    }```
Thanks

@Identitaet
Copy link
Collaborator

  1. Yes

Taiwan is just TW
Reunion Island is RE
and the other ones seem to just be duplicates due to translation in Itallian
Portogallo = Portugal with the country code PT
Mozambico = Mozambique with the country code MZ

@joey2031
Copy link
Contributor

Thanks! Just submitted a PR. If there is anything I missed just let me know! Have a great day.

@bhousel
Copy link
Member

bhousel commented Oct 10, 2020

Thanks @joey2031 !

I keep these pages bookmarked to lookup the codes:

code url
Countries / ISO 3166-1 https://en.wikipedia.org/wiki/List_of_countries_by_United_Nations_geoscheme
Regions / M.49 https://en.wikipedia.org/wiki/UN_M49

Sometimes it can be easier to use the region codes instead of adding a whole lot of country codes. Either way is fine.

@pyrog
Copy link
Contributor Author

pyrog commented Oct 11, 2020

Thanks guys 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add brand Actionable - add a brand to the index
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants