Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion : store NSI data in the OSM wikibase #4657

Closed
pyrog opened this issue Nov 9, 2020 · 8 comments
Closed

Suggestion : store NSI data in the OSM wikibase #4657

pyrog opened this issue Nov 9, 2020 · 8 comments
Labels
waitfor Waiting for something before we can do this

Comments

@pyrog
Copy link
Contributor

pyrog commented Nov 9, 2020

The OSM wikibase (aka Data Items) is (or will be) the repository of OSM keys, tags, concepts…

One don't need to write an issue or a PR, just create a new data item and add properties 😃

@nyurik

@bhousel
Copy link
Member

bhousel commented Nov 9, 2020

Is there anything actionable for us to do?

@Identitaet
Copy link
Collaborator

I guess the idea is to expand the wikidata script to also add the nsi entries (and all the tags) into the OSMwikibase ?

@pyrog
Copy link
Contributor Author

pyrog commented Nov 9, 2020

First, "discussed" if it could be a good point for NSI project and OSM 😃
It could avoid a lot of issue… and time waiting for a PR.

But, we could write code for the website to add and edit "brand"…
Or code to convert NSI files to Quick Statements or CSV to import them.
Or do that with a SPARQL query ??

@bhousel
Copy link
Member

bhousel commented Nov 9, 2020

Sorry @pyrog but I still don't really understand what this issue is about.
I'm happy to push the NSI data to another system with a script, but need some more guidance.

@nyurik
Copy link

nyurik commented Nov 9, 2020

I'm all for storing critical OSM metadata in the data items, but we should discuss all the logistics of that process -- how items are added, if we should have an extra UI for it, how downstream projects consume such information, issue resolution, etc.

@pyrog
Copy link
Contributor Author

pyrog commented Nov 9, 2020

I'm all for storing critical OSM metadata in the data items

Nice 😃

we should discuss all the logistics of that process

👍 Where, here ?

how items are added ?

  • For existing brands, a script is needed to import data from NSI :
    • SPARQL ?
    • QuickStatements ?
    • python
    • @nyurik What do you suggest ?
  • For new brands :
    • From the NSI Website ?
    • Manually ?
      The "Create a new Item" link is removed from the wiki.
      For test purpose, I created the Data Item Q21418 😉
    • From the "wiki" with a "template" in common.js ?

how downstream projects consume such information
With a SPARQL Query.

Currently JOSM do that to fetch formatter URL (P8).
iD also query Data Items and Wikidata (at least in iD/modules/services/osm_wikibase.js#L131)

@bhousel
Copy link
Member

bhousel commented Nov 10, 2020

how items are added ?

We already use a node.js script to sync up all the NSI items to Wikidata so we'd probably just use that same script (or one just like it) to push our data to OSM's wikibase too.

@bhousel bhousel added the waitfor Waiting for something before we can do this label Nov 11, 2020
@bhousel
Copy link
Member

bhousel commented Feb 24, 2021

stale

@bhousel bhousel closed this as completed Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waitfor Waiting for something before we can do this
Projects
None yet
Development

No branches or pull requests

4 participants