Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle new format in name-suggestion-index #4931

Closed
nuxper opened this issue Mar 1, 2021 · 3 comments
Closed

Handle new format in name-suggestion-index #4931

nuxper opened this issue Mar 1, 2021 · 3 comments
Assignees

Comments

@nuxper
Copy link
Collaborator

nuxper commented Mar 1, 2021

name-suggestion-index output file "nsi.json" had a change in format.
For each tag path (for ex. brands/amenity/atm), the nsi.json now contains:

  • a "properties" element containing a dictionary
  • a "items" element containing the list of brands / operators.

I create this issue to track the update of TagFix_brand.py to follow this change of format.

The change is ready. I'll create a PR in a moment.

@nuxper nuxper self-assigned this Mar 1, 2021
@UKChris-osm
Copy link
Collaborator

Is this in reference to Osmose backend? osm-fr/osmose-backend#1202

@nuxper
Copy link
Collaborator Author

nuxper commented Mar 2, 2021

Arg you are right. I created the issue on the wrong project!!!

@nuxper nuxper closed this as completed Mar 2, 2021
@bhousel
Copy link
Member

bhousel commented Mar 4, 2021

Yes sorry for the changes from #4906, as we get ready for a more formal release.
We are pretty close to releasing V5 for real, so I don't think the file format will change anymore..
(One good thing about having properties in a dedicated properties: {} object is that we can add stuff without changing the file format anymore).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants