Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong suggestion for Coop (Sweden) #5505

Closed
bhousel opened this issue Oct 14, 2021 · 7 comments
Closed

Wrong suggestion for Coop (Sweden) #5505

bhousel opened this issue Oct 14, 2021 · 7 comments

Comments

@bhousel
Copy link
Member

bhousel commented Oct 14, 2021

from @JohanEntur on #5500

We are not regulars, but NKA is really speaking for the rest of us (Norway) here. Individual shop names is a thing, and NKA has put a lot of work into building several import structures (incl. shops) to both populate and keep these POIs up to date in Norway. It would be unfortunate if the presets and users of iD would unwittingly degrade these items.

I can tell you right now, the same issue will be relevant for Sweden:
The suggestion iD gives here is not sound.
image

Originally posted by @JohanEntur in #5500 (comment)

@bhousel
Copy link
Member Author

bhousel commented Oct 14, 2021

I split this off from the rest of the thread on #5500 to better address it.
@JohanEntur can you say more about what's wrong about this suggestion? As far as I can tell the suggestion looks correct and is a significant improvement.

@JohanEntur
Copy link

I don't feel like I either know enough about the subject, despite local knowledge or that I care very strongly - and I can't be bothered with all the argumentation. But basically, if I was mapping out that city and I saw that it had "name=Coop" I would probably re-tag that because that's not how it's known locally. It's Coop @ Palmviken and the official name is "Stora Coop Palmviken", https://www.coop.se/butiker-erbjudanden/stora-coop/stora-coop-palmviken/. I haven't been there for a while but I think the signs on the building will to some extent reflect this (they keep changing the name and the signs).

It is also to differentiate it from the other Coop in town https://www.openstreetmap.org/node/2271656207. I know that it has the branch tag and all that, but the name field irks me :) It doesn't sit right with me.

Either way, the argumentation is the same as in the case with the Norwegian issue, so whatever happens there could be applied here.

I have no problem with the added tags, just the change of the name tag.

@bhousel
Copy link
Member Author

bhousel commented Oct 14, 2021

I have no problem with the added tags, just the change of the name tag.

Ok that is helpful to hear.. I added the preserveTags property to a bunch of Swedish and Norwegian supermarket and convenience stores so that the validator shouldn't suggest a name change for these.

You will probably still see some other places where this name -> name+branch split gets suggested until we figure out a longer term fix for #5500. If it's really wrong, open an issue for it, but please avoid accusations of "unwittingly degrading" the tags on the items.

@JohanEntur
Copy link

If you build a perfect human-to-human communication interface I'll transfer the exact meaning of what I wanted to convey with those specific words :) Until then, read with soft eyes.

I'll drop you a line if I see something new.

@Adamant36
Copy link
Collaborator

I can't be bothered with all the argumentation.

Just an FYI, you could read the "arguing" with soft eyes also. Since anything can be called "arguing" until someone builds a perfect human-to-human communication interface that transfers the exact meaning of what people want to say, or whatever.

@JohanEntur
Copy link

@Adamant36 Why all this aggro? I said argumentation. It means I have no strong feelings on the matter. Leave it.

@Adamant36
Copy link
Collaborator

Adamant36 commented Oct 14, 2021

"Argumentation" has a negative connotation and I think most people in the original discussion were making a good faithed effort to find the best solution. That's all. In the meantime, I'm not being agro. I could ultimately care less about this. Aside from that I think its an interesting subject. So I participated in the discussion. Don't read more then that into things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants